<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">Am 19.09.2013 18:57, schrieb hermann
meyer:<br>
</div>
<blockquote cite="mid:523B2CDD.6000307@web.de" type="cite">
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
<div class="moz-cite-prefix">Am 19.09.2013 17:50, schrieb IOhannes
m zmoelnig:<br>
</div>
<blockquote cite="mid:523B1D29.4000902@iem.at" type="cite">
<pre wrap="">-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 2013-09-19 17:18, hermann meyer wrote:
</pre>
<blockquote type="cite">
<pre wrap="">Am 19.09.2013 16:50, schrieb IOhannes m zmoelnig:
</pre>
<blockquote type="cite">
<pre wrap="">-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On 2013-09-19 05:31, hermann meyer wrote:
</pre>
<blockquote type="cite">
<pre wrap="">I'm sad to hear that. :-( Please don't let you lead from the
things you didn't like, let you lead from the things you like
instead. I guess then it's necessary to let you know that we
use /as well/ a fork of your work, the zita-convolver library,
in the guitarix project. But we leave your copyright untouched,
and the fork will only come in use, when the user set a
explicit compile flag. We didn't promote it, or force the fork.
Ordinary your original code is in use. We do it to use ffmpeg
instead fftw3 FFT, which perform better on ARM devices.
</pre>
</blockquote>
<pre wrap="">but this sounds like the perfect opportunity to not do a simple
fork, but to send patches to upstream so fons' aeolus could
support both fftw3 and ffmpeg FFTs. it might be a win-win
situation, where not only more than just the original aeolus
users can profit from fons' work (because you use his code) but
also more than just your users can profit from your work (because
you changes are included into upstream aeolus).
</pre>
</blockquote>
<pre wrap="">Sorry, you miss-match aeolus and zita-convolver here.
</pre>
</blockquote>
<pre wrap="">ah yeah, sorry. pleas do s/aeolus/zita-convolver/g in my answer.
</pre>
<blockquote type="cite">
<pre wrap="">As well, we didn't "add" ffmpeg support to zita-convolver, we
replace fftw3 with ffmpeg, and only use this under special
circumstances (ARM support),
</pre>
</blockquote>
<pre wrap="">i'm not sure what you mean.
zita-convolver depends on FFTW3 for doing the FFTs.
if you "replace fftw3 with ffmpeg", you create modifications to
zita-convolves to not use fftw3 anymore (in some special
circumstances), and instead use ffmpeg's FFT (whether as a library or
statically compiled in).
in any case, this seems to be a substantial change to some parts of
zita-convolver, so you should definitely add your copyright to the
files you modified (substantially).
</pre>
</blockquote>
<br>
No, a disclaimer in the source tree which clarify this will be
enough. <br>
<blockquote cite="mid:523B1D29.4000902@iem.at" type="cite">
<blockquote type="cite">
<pre wrap="">we didn't distribute it as "zita-convolver library"
</pre>
</blockquote>
<pre wrap="">so?
it seems that you did distribute it "in some form" (else what are we
talking about?).
MuseScore doesn't distribute a disfigured version of "Aeolus" in order
to pile praise upon themselves and/or to denounce fons. they
distribute "MuseScore" which comes bundled with a version of Aeolus
that integrates into their system.
similar goes for Maurizio: he has a project called "oscAeolus" which
makes it quite clear that it is a derivative of Aeolus (and not the
real thing itself).
</pre>
</blockquote>
<br>
That's why I wrote <br>
<br>
<blockquote type="cite">
<pre wrap="">On 2013-09-19 05:31, hermann meyer wrote:
</pre>
<blockquote type="cite" style="color: #000000;">
<pre wrap="">.... I guess then it's necessary to let you know that we use <i class="moz-txt-slash"><span class="moz-txt-tag">/</span>as well<span class="moz-txt-tag">/</span></i> a
fork of your work, the zita-convolver library, in the guitarix
project.</pre>
</blockquote>
</blockquote>
we do exactly the same, we modify the source to our needs. <br>
</blockquote>
<br>
EDIT:<br>
Sorry, not "exactly the same", we contacted Fons before we start to
use/include his work in our project. <br>
<br>
<blockquote cite="mid:523B2CDD.6000307@web.de" type="cite"> We have
done the same with zita-resampler for some time, as long Fons
takes to include the provided patch. <br>
<br>
<blockquote cite="mid:523B1D29.4000902@iem.at" type="cite">
<blockquote type="cite">
<pre wrap="">No useful patch is available.
</pre>
</blockquote>
<pre wrap="">i didn't say that contributing is easy.
more often than not it requires a lot of work and interaction with
upstream until you have prepared a patch that can be accepted.
what i did say is that you should make a useful patch available.
</pre>
</blockquote>
This is pretty new, and we have a lot stuff where we are working
on. <span class="moz-smiley-s3"><span> ;-) </span></span><br>
I could provide a diff, which shows the changes.<br>
<br>
<br>
<blockquote cite="mid:523B1D29.4000902@iem.at" type="cite">
<pre wrap="">
i'd love to see a zita-reverb that performs "ideally" on all platforms
(and that unfortunately includes ARM-systems by now)
</pre>
</blockquote>
I'm not aware of any relation between zita-reverb and
zita-convolver.<br>
<br>
greets<br>
hermann<br>
<br>
</blockquote>
<br>
</body>
</html>