[linux-audio-dev] [PATCH] oss driver for jack 0.90.0 - the actual patch :)

[Paul Davis]

>Looks like I forgot to attach the patch...

i don't think this patch isn't ready to be added to CVS yet:

  1) the null cycle callback is wrong. it will generate random noise, and
       should instead generate silence.

  2) the buffer size callback is wrong. you have to stop the hardware,
       reset the period size, and then restart the hardware.

  3) is there a reason why you are not using bob's infrastructure for
       APIs without their own thread? it seems wasteful to duplicate
       this again. the OSS driver should be like the ALSA one in this
       respect.

also, do you understand the outcome of the discussions Jack O'Quinn
and i had about adding this driver to JACK? to be specific:
       
          * there is no guarantee or even offer that the driver will
	    be maintained. 

          * if JACK internals change, and the driver is not updated to
	    follow the change before a release, it will be removed
	    from the release, and it is possible that it will not be
	    added back. 

          * likewise for new features added to JACK that rely on
	    a driver-side implementation. this is why its important
	    that the buffer size callback works correctly, for example.

joq is correct that adding a new driver adds a real burden to the
core JACK team. if you are unwilling to commit to maintaining the
driver to keep track with other JACK changes, then we should not add
it to CVS.
  
--p