[linux-audio-dev] hearnet improvement

Dmitry Baikov dsbaikov at gmail.com
Thu Oct 5 18:00:36 UTC 2006


Hi!
First of all, thanks for a great program!

I made two patches for it:
1) make hearnet suid and drop privileges right after libpcap initialization.
 I had to move libpcap init code above jack

So, you can use hearnet as regular user.

2) Mutex in jack_process is a very bad thing. Moreover, it seems
there's no need for it, as voice->active field serves as a mutex.
Attached patch removes pthread_mutex.
If you think voice->active assumption is a weak one, the problem can
be solved with a pair of jack_ringbuffers: one for free voices and one
for active.


Regards,

Dmitry.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: privdrop.patch
Type: text/x-patch
Size: 1399 bytes
Desc: not available
URL: <http://lists.linuxaudio.org/pipermail/linux-audio-dev/attachments/20061005/1a7f99aa/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: nomutex.patch
Type: text/x-patch
Size: 1182 bytes
Desc: not available
URL: <http://lists.linuxaudio.org/pipermail/linux-audio-dev/attachments/20061005/1a7f99aa/attachment-0001.bin>


More information about the Linux-audio-dev mailing list