[LAD] [Jackit-devel] [PATCH] jack dbus and logs improvement

[Nedko Arnaudov]

Dave Robillard <dave at drobilla.net> writes:

> Hi all,
>
> Attached is a big patch of nedko's logs, midi, and dbus changes with
> modifications.  I removed the (IMO confusing and unnecessary) split of
> jackd (nuking some redundant code) and made the single jackd executable
> work as it always has, or in dbus control mode when run as jackd --dbus
>
> Example:
>
> $ ps aux | grep jack
> dave     19064  0.0  0.0   3920   572 pts/2    S+   20:56   0:00
> 	grep jack
>
>
> $ jack_control start
> --- start
>
>
> $ ps aux | grep jack
> dave     19067  0.5  0.2  74992  5804 ?        Ssl  20:56 0:00
> 	/usr/local/bin/jackd --dbus
> dave     19073  0.0  0.0   3916   568 pts/2    S+   20:56   0:00
> 	grep jack
>
>
> $ jack_control stop
> --- stop
>
> $ ps aux | grep jack
> dave     19076  0.0  0.0   3920   572 pts/2    S+   20:56   0:00
> 	grep jack 
>
> (All other jackd args and functionality remain completely unchanged).

I'd like to hear what other ppl think about this. It works for me both
ways. If most ppl like to have two modes merged in one executable just
to see jackd is running not jackdbus, so be it, I'll merge those changes
into dbus patch.

> Also fixed quite a few warnings and doxygen errors.

Having those as separate patches for review and commit in trunk would be
great.

> Remote controllable jackd is nice, but first thing's first:  It would
> REALLY be nice to have nedko's jackd-midi-alsa-munge and jack-logs
> patches applied to trunk to kill the intolerably awful midi port naming
> problem and shrink the size of this behemoth patch.  Both are
> straightforward, fix things that need fixing, and break nothing.
>
> PLEASE? :)

PLEASE? :)

> Attached patch is against most recent SVN, R1070

It is not usable directly. At least it misses some files introduced by
the dbus patch:
jackd.c:43:22: error: jackdbus.h: No such file or directory

-- 
Nedko Arnaudov <GnuPG KeyID: DE1716B0>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 188 bytes
Desc: not available
URL: <http://lists.linuxaudio.org/pipermail/linux-audio-dev/attachments/20071218/69a61767/attachment.pgp>