[LAU] Evil JACK trouble (FIXED, got a patch!)

[Hermann Meyer]

Hi Julien

Thanks for submit ! It works for me. 
Paul Davis is a member of this list, so he will read it soner or later. I 
remember that I read a Post from him at jack-devel where he ask for testing 
to bring out a new release. So it will be good to fix jack_connect in svn.
I diff your version against the fresh svn outcheck :

-- jack/tools/connect.c	2008-06-06 16:19:55.000000000 +0200
+++ jack/tools/connect.c	2008-07-15 17:33:02.000000000 +0200
@@ -111,7 +111,10 @@
 		return 1;
 	}
 
-	if (argc < 3) show_usage(my_name);
+	if (argc < 3) {
+		show_usage(my_name);
+		return 1;
+	}
 
 	/* try to become a client of the JACK server */
 
@@ -130,11 +133,11 @@
 
 	/* find the two ports */
 
-	if ((input_port = jack_port_by_name(client, argv[argc-1])) == 0) {
+	if ((input_port = jack_port_by_name(client, argv[argc-2])) == 0) {
 		fprintf (stderr, "ERROR %s not a valid port\n", argv[argc-1]);
 		return 1;
-		}
-	if ((output_port = jack_port_by_name(client, argv[argc-2])) == 0) {
+	}
+	if ((output_port = jack_port_by_name(client, argv[argc-1])) == 0) {
 		fprintf (stderr, "ERROR %s not a valid port\n", argv[argc-2]);
 		return 1;
 		}



regards   (Danke Julien)  hermann

Am Dienstag, 15. Juli 2008 16:03:41 schrieb Hermann Meyer:
> Hi Julien
>
> send it to me !! please
> and the jack-devel list will be a good place to.
> http://lists.jackaudio.org/listinfo.cgi/jack-devel-jackaudio.org
> or
> http://www.nabble.com/Jack-Audio-f15500.html
>
> regards     hermann
>
> Am Dienstag, 15. Juli 2008 15:45:33 schrieb Julien Claassen:
> > Hi everyone!
> >    I fixed the connect.c from jack 0.112.0. It was mainly some confusing
> > inputs with outputs and forgetting a return statement.
> >    Whom to send the file now?
> >    Kindest regards
> >          Julien