[LAU] Jack 1 vs. 2

[Fons Adriaensen]

On Fri, Feb 05, 2021 at 10:54:23AM +0000, Filipe Coelho wrote:

> 1. convert entire jack1 code to a specific style [1]
> 2. apply your (unclean) patch in a different jack1 copy and convert that
> entire codebase too
> 3. make a diff out of the 2 to have a clean patch [2]
> It turns out the end result did not work well, so it had to be reverted [3]

It certainly worked very here and was used to run some very big
systems for years without any problem. I only switched to Jack2
later in order to have the advantage of multiple CPUs.

> Paul went to the extra effort of cleaning up the entire codebase just to
> accept the patch from you, but somehow that didnt work (why exactly I dont
> know).

I should probably have presented the entire modified source
instead of patch. Test it, if it works just check it in and
let the version control system find the deltas. Clean up
the style afterwards if you want. 

The 1,2,3 above is quite a fragile process, I'm not surprised
it didn't work out well.

I went to the trouble of reformatting some of the original code
just to be able to read and understand it, which would have been
near impossible otherwise. It was only done where the e.g. the
indentation was wrong, sometimes spanning multiple screens, and
utterly misleading in the original. Or where I had to strain my eyes
trying to parse verylongstringsconsistingofvariablenamesandmathoperatorswithoutanywhitespace.

The original code wasn't clean to start with. 

Ciao,

-- 
FA