17 Oct
2006
17 Oct
'06
2:49 p.m.
I did reply to Dmitry earlier by email, but for posterity, I integrated
his patch and released a new version. I think I posted to the announce
list but I'm not sure if it came through or not. If not, head on over to
http://hans.fugal.net/typo/articles/2006/10/10/hearnet-0-0-9
On Thu, 5 Oct 2006 at 22:00 +0400, Dmitry Baikov wrote:
Hi!
First of all, thanks for a great program!
I made two patches for it:
1) make hearnet suid and drop privileges right after libpcap initialization.
I had to move libpcap init code above jack
So, you can use hearnet as regular user.
2) Mutex in jack_process is a very bad thing. Moreover, it seems
there's no need for it, as voice->active field serves as a mutex.
Attached patch removes pthread_mutex.
If you think voice->active assumption is a weak one, the problem can
be solved with a pair of jack_ringbuffers: one for free voices and one
for active.
Regards,
Dmitry.
--
Hans Fugal ; http://hans.fugal.net
There's nothing remarkable about it. All one has to do is hit the
right keys at the right time and the instrument plays itself.
-- Johann Sebastian Bach