12 Sep
2004
12 Sep
'04
5:05 a.m.
On Sun, Sep 12, 2004 at 02:06:53AM -0400, Lee Revell wrote:
OK, patch has been posted to LKML...
http://lkml.org/lkml/2004/9/12/22
Shouldn't you use in_group_p() instead of searching the grouplist
yourself? in the new kernels, groups are sorted, so in_group_p uses a
binary search. Also, the ifdef will never fly. Also, don't put a blank
line after "if (....) {" - you do that in a couple places.
Nitpicking before Linus and Andrew do it for you :)