15 Feb
2023
15 Feb
'23
12:29 p.m.
On Tue, Feb 14, 2023 at 04:55:00PM +0100, Wim Taymans wrote:
I don't think this is correct. But it may be a long time before
this becomes apparent.
Frame times are 32 bit. The required result of the subtraction is
the difference modulo 2^32 and interpreted as an int32_t
i.e. including the wraparound resulting from the 'exact' value
being out of range for an int32_t.
The wraparound won't happen when frametimes are cast to 64 bit.
Ciao,
--
FA
BTW, what
about the 'signed differences' issue I pointed
out earlier ?
Should be fixed with this:
https://gitlab.freedesktop.org/pipewire/pipewire/-/commit/274b63e9723ec00dd…