26 May
2006
26 May
'06
11:45 a.m.
On Fri, May 26, 2006 at 10:25:57PM +1000, Erik de Castro Lopo wrote:
karsten wiese wrote:
no, stefan's patch is correct. the macro reads:
#define AUBIO_MEMSET(_dst,_src,_t) memset(_dst,_src,sizeof(_t))
>
> As usual, the source code can be found at http://aubio.piem.org/ ,
> and Debian packages are available from http://piem.org/debian/ .
Errm, this looks really weird.
@@ -41,7 +41,7 @@
aubio_sndfile_t * new_aubio_sndfile_ro(const char* outputname) {
aubio_sndfile_t * f = AUBIO_NEW(aubio_sndfile_t);
SF_INFO sfinfo;
- AUBIO_MEMSET(&sfinfo, 0, sizeof (sfinfo));
+ AUBIO_MEMSET(&sfinfo, 0, sfinfo);
sfinfo.format = 0;
f->handle = sf_open (outputname, SFM_READ, &sfinfo);
Are you sure you don't have diff direction wrong? If you have a macro called X_MEMSET with very similar
arguments
to the standard C function, the macro should have the same
symanics as the function it wraps. If you don't, you will confuse
people.
well, indeed i got confused myself. this also explains the 'strange'
sndfile behavior i found on powerpc, wrongly 'fixed' with the
sfinfo.format = 0 line.
thanks for reporting this Stefan, it will be fixed soon.
bye, Paul