18 Dec
2007
18 Dec
'07
10:47 a.m.
Nedko Arnaudov wrote:
Agreed. Mixing several unrelated fixes in one patch is just wrong.
Having multiple patches to apply in order to test the dbus version is
inconvenient.
I guess things like doxygen comment fixes can be safely committed in
trunk without risking severe regressions, so why not do it? :) :) :)
PLEASE? :)
(ok, maybe I should read those patches first!)
Can't check it now (still at work).
Krzysztof
I'd like to hear what other ppl think about this.
It works for me both
ways. If most ppl like to have two modes merged in one executable just
to see jackd is running not jackdbus, so be it, I'll merge those changes
into dbus patch.
I'm definitely in favour of the merge. The previous solution (old jackd,
new jackdbus) was definitely confusing to me. While I understand the
distinction now, it wasn't obvious at first.
Also fixed
quite a few warnings and doxygen errors.
Having those as separate patches for
review and commit in trunk would be
great. Remote
controllable jackd is nice, but first thing's first: It would
REALLY be nice to have nedko's jackd-midi-alsa-munge and jack-logs
patches applied to trunk to kill the intolerably awful midi port naming
problem and shrink the size of this behemoth patch. Both are
straightforward, fix things that need fixing, and break nothing.
PLEASE? :)
PLEASE? :) Attached patch
is against most recent SVN, R1070
It is not usable directly. At least it misses
some files introduced by
the dbus patch:
jackd.c:43:22: error: jackdbus.h: No such file or directory