On Mon, 2010-02-01 at 11:37 +1100, Erik de Castro Lopo wrote: Well, MPEG 1 layer II is (as far as I can tell) due to expire this year and supporting it as both a raw mp2 file and as a compression type for wav would make my day, along with many others that have to work with radio broadcast related things..... At the moment I try libsndfile then if that fails do the pipe, dup2 and execve thing to shovel it through an external decoder, but it is a lot of code that would be better in the library. Patch acceptable once it finally expires? Regards, Dan.

On Mon, 2010-02-01 at 11:53 +1100, Erik de Castro Lopo wrote: While that is undeniably a hack of the first order, it does hide a certain truth in that a lot of the lossy audio codecs out there have a bit of a reputation for memory leaks, and doing the job in a child process takes care of that matter rather neatly. In fact the background file converter daemon I am writing at the moment does a fork and exec for every conversion precisely to insulate from possible memory leaks in client libraries used by libsndfile (can you swear that the ogg and flac libraries don't have leaks?), it is just defensive programming...... But yea, code for libsndfile would need to be something much cleaner then shelling out to twolame. Regards, Dan.

I didn't consider this point, and its truly one to think about. But since major projects also use sndfile and mad (like ardour uses sndfile), and the use of them simplifies the code, I still favour them over using external apps. Another thing, we should better open a sourceforge project for tX with svn. Gerald On Mon, 2010-02-01 at 12:23 +1100, Erik de Castro Lopo wrote:

So what do you suggest? Gerald On Sat, 2010-02-06 at 18:48 +0100, torbenh wrote:

What are the benefits of using Git rather than svn? Gerald On Wed, 2010-02-10 at 08:04 -0600, Gabriel M. Beddingfield wrote:

I'd rather suggest to use libmad for mp3's, since the old code did the same thing: Loading the files with external programs and piping them into tX. I wanted to get rid of that, cause it looks awfull in code. You can see it in audiofile.cpp. With sndfile and mad we have 2 libs for all common file types. Gerald On Mon, 2010-02-01 at 11:53 +1100, Erik de Castro Lopo wrote:

On Mon, Feb 1, 2010 at 6:46 AM, Dave Phillips <dlphillips(a)woh.rr.com> wrote: probably caused by a change in JACK some years ago when we began to have the server call any samplerate callback during client startup to make sure the client had a race-free way to discover the SR. my guess is that tX is written with the belief that the SR callback will never be called, which is correct in the sense that the SR will never be changed, but incorrect in that it will still be called once.

Am 01.02.2010 11:50, schrieb gerald mwangi: Gerald, do you need the files decoded into memory? You could consider doing a gstreamer based loader for the formats that are not covered by libsndfile? Then you can load mp3, aac and heck what not (e.g. loading mod files or sid songs as well). I have such code in buzztard and can point you where it is and how it works (maybe offline discussion if people are not interested in the details). Stefan