29 Jun
2005
29 Jun
'05
8:56 a.m.
Hello all!
I have a problem with creating a plugin with more than one control
port. In the attachment you'll find "booster-simple.c" which has one
"Gain" port and my attempt to add a second port in "booster.c". For
some reason the latter cannot be used - the sources seem to be
correct, it compiles fine, but then if I test with "applyplugin" it
segfaults and other hosts complain about a malloc() error and hang.
Debugging shows that ports are not properly connected:
[connectPortToBooster] setting BOOSTER_INPUT1
[connectPortToBooster] setting BOOSTER_OUTPUT1
[runMonoBooster]
applyplugin: booster.c:112: runMonoBooster: Assertion
`psBooster->m_pfGainValue != 0' failed.
...but I cannot investigate further as my C is very basic.
I would really appreciate any help. I based my plugin on the amp.c
from the SDK, and I see that in example plugins like simple delay
(where there is more than one control port) memory allocation is done
differently, but I just don't know how to properly apply these
techniques to my plugin...
Thanks very much!
Artemiy.
P.S. I've sent a message with a 50Kb attachment and it's in moderation
queue, but these sources are newer.
29 Jun
29 Jun
9:37 a.m.
On Wed, Jun 29, 2005 at 01:57:58PM +0300, Artemio wrote:
I have a problem with creating a plugin with more than
one control
port. In the attachment you'll find "booster-simple.c" which has one
"Gain" port and my attempt to add a second port in "booster.c". For
some reason the latter cannot be used - the sources seem to be
correct, it compiles fine, but then if I test with "applyplugin" it
segfaults and other hosts complain about a malloc() error and hang.
This is a *horribly complicated* way of doing something that could be
so simple. You need just one malloc() [1] and one free [2], and the
whole of init() including all the strdup() calls can be replaced by
some static declarations.
If you want to see some examples of this, get any of the plugins at
<users.skynet.be/solaris/linuxaudio> and have a look at one of the
*_if.cc files. The plugins are C++, but to convert this to C would be
trivial, and most of the *_if.cc is plain C anyway.
[1] in instantiate(), to allocate a struct that contains all the data
for one instance, i.e. port pointers and any state that must be kept
between calls to run().
[2] in cleanup(), to release the same.
--
FA
9:42 a.m.
On Wed, 2005-06-29 at 13:57 +0300, Artemio wrote:
I have a problem with creating a plugin with more than
one control
port. In the attachment you'll find "booster-simple.c" which has one
"Gain" port and my attempt to add a second port in "booster.c". For
some reason the latter cannot be used - the sources seem to be
correct, it compiles fine, but then if I test with "applyplugin" it
segfaults and other hosts complain about a malloc() error and hang.
From booster.c:
#define BOOSTER_INPUT1 0
#define BOOSTER_OUTPUT1 1
#define BOOSTER_INPUT2 2
#define BOOSTER_OUTPUT2 3
#define BOOSTER_GAIN 4
#define BOOSTER_ASYMMETRY 5
...
g_psMonoDescriptor->PortCount = 4;
piPortDescriptors = (LADSPA_PortDescriptor *)calloc(4,
sizeof(LADSPA_PortDescriptor));
g_psMonoDescriptor->PortDescriptors
= (const LADSPA_PortDescriptor *)piPortDescriptors;
piPortDescriptors[BOOSTER_GAIN] = LADSPA_PORT_INPUT|LADSPA_PORT_CONTROL;
piPortDescriptors[BOOSTER_ASYMMETRY] =
LADSPA_PORT_INPUT|LADSPA_PORT_CONTROL;
piPortDescriptors[BOOSTER_INPUT1] = LADSPA_PORT_INPUT|LADSPA_PORT_AUDIO;
piPortDescriptors[BOOSTER_OUTPUT1] =
LADSPA_PORT_OUTPUT|LADSPA_PORT_AUDIO;
First you set the PortCount to 4 and allocate an array of 4
LADSPA_PortDescriptor variables, and then you try to access index
BOOSTER_GAIN and BOOSTER_ASYMMETRY in the array, which are defined as 4
and 5. That is bound to cause all sorts of problems.
--
Lars Luthman
PGP key: http://www.d.kth.se/~d00-llu/pgp_key.php
Fingerprint: FCA7 C790 19B9 322D EB7A E1B3 4371 4650 04C7 7E2E
10:28 a.m.
Thank you soooo much Lars and Fons!!!
Yes, I realised my mistake with defining the port numbers, and once I
fixed everything started working like charm!
I really appreciate your help, guys. Thanks a lot!
With kindest regards,
Artemiy,
7082
days inactive
7082
days old
linux-audio-dev@lists.linuxaudio.org
3 comments
3 participants
participants (3)
-
Alfons Adriaensen -
Artemio -
Lars Luthman