27 Sep
2009
27 Sep
'09
5:49 p.m.
Folderol wrote:
The attached patch (Sharp Synth)behaves very
differently on yoshimi to
zyn. The notes C1 to F1 and C2 to F2 are extremely dull sounding, and
the overall level is higher.
I can't really pin it down, but my suspicion is that yoshimi is
ignoring the resonance setting and applying it's own strange one.
I need to wait for the sun to come up before I get too serious with it,
but this just might be the error in question -
{{{
--- yoshimi-dev.orig/src/Synth/Resonance.cpp
+++ yoshimi-dev/src/Synth/Resonance.cpp
@@ -67,8 +67,10 @@
for (int i = 1; i < n; ++i)
{
- float x = (logf(freq * i) - l1) / l2;
// compute where the n-th hamonics fits to the graph
+ float x = (logf(freq * i) - l1) / l2;
+ if (x < 0.0)
+ x = 0.0;
x *= N_RES_POINTS;
float dx = x - floorf(x);
@@ -99,8 +101,10 @@
sum = Prespoints[i];
if (sum < 1.0)
sum = 1.0;
- float x = (logf(freq) - l1) / l2;
// compute where the n-th hamonics fits to the graph
+ float x = (logf(freq) - l1) / l2;
+ if (x < 0.0)
+ x = 0.0;
x *= N_RES_POINTS;
float dx = x - floorf(x);
}}}